lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] exit: Retain nsproxy for exit_task_work() work entries
On Wed, Dec 08, 2021 at 12:45:54PM -0600, "Eric W. Biederman" <ebiederm@xmission.com> wrote:
> TL;DR the cgroup file system is checking permissions at write time.

Thank you for bringing that up (handled in a separate thread now).

> I think I follow your reasoning and I think it will even fix the issue
> but no.

FTR, part of Tejun's series [1] ensures that cgroup_ns is accessed
directly without nsproxy and a reference to it is kept while the file
is opened. I.e. that'd properly fix this particular crash reported by
syzbot.

> Please don't apply this patch.
>
> exit_task_work running after exit_task_namespaces is the messenger
> that just told us about something ugly.

In (my) theory some other task_work callbacks could (transitively) rely
on the current->nsproxy which could still be cleared by
exit_task_namespaces().
Is there another reason why to have exit_task_namespaces() before
exit_task_work()?

Thanks,
Michal

[1] https://lore.kernel.org/r/20211209214707.805617-4-tj@kernel.org/

\
 
 \ /
  Last update: 2021-12-11 00:13    [W:0.107 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site