Messages in this thread |  | | Subject | Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback | From | German Gomez <> | Date | Wed, 6 Oct 2021 10:35:20 +0100 |
| |
Hi Leo,
Many thanks for your comments.
On 04/10/2021 13:27, Leo Yan wrote:
> Hi German, > > On Thu, Sep 30, 2021 at 01:26:15PM +0100, German Gomez wrote: > > [...] > > So simply say, I think the head pointer monotonically increasing is > the right thing to do in Arm SPE driver.
I will talk to James about how we can proceed on this.
>> (note that the patch will skip the wrap-around detection if this is the >> case, >> in order to handle both cases in the userspace perf tool). > Almost agree, I read multiple times but have no idea what's the > "both cases" in the last sentence.
Apologies for the later part was not clear. What I meant to say was that in the original patch for cs-etm, it seemed to handle both cases where AUX head might be monotonically and non-monotonically increasing, so we applied the same for the Arm SPE patch.
> > Please let me know if anything is not clear. > > Thanks, > Leo > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/auxtrace.c#n1804
|  |