[lkml]   [2021]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/20] signal/s390: Use force_sigsegv in default_trap_handler
On Wed, Oct 20, 2021 at 12:43:57PM -0500, Eric W. Biederman wrote:
> Reading the history it is unclear why default_trap_handler calls
> do_exit. It is not even menthioned in the commit where the change
> happened. My best guess is that because it is unknown why the
> exception happened it was desired to guarantee the process never
> returned to userspace.
> Using do_exit(SIGSEGV) has the problem that it will only terminate one
> thread of a process, leaving the process in an undefined state.
> Use force_sigsegv(SIGSEGV) instead which effectively has the same
> behavior except that is uses the ordinary signal mechanism and
> terminates all threads of a process and is generally well defined.
> Cc: Heiko Carstens <>
> Cc: Vasily Gorbik <>
> Cc: Christian Borntraeger <>
> Cc:
> Fixes: ca2ab03237ec ("[PATCH] s390: core changes")
> History Tree:
> Signed-off-by: "Eric W. Biederman" <>

Reviewed-by: Kees Cook <>

Kees Cook

 \ /
  Last update: 2021-10-21 18:19    [W:0.417 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site