[lkml]   [2021]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 0/8] Remove dependency on congestion_wait in mm/
On Tue, 19 Oct 2021, Mel Gorman wrote:
> Changelog since v3
> o Count writeback completions for NR_THROTTLED_WRITTEN only
> o Use IRQ-safe inc_node_page_state
> o Remove redundant throttling
> This series is also available at
> git:// mm-reclaimcongest-v4r2
> This series that removes all calls to congestion_wait
> in mm/ and deletes wait_iff_congested.

Thanks for this.
I don't have sufficient expertise for a positive review, but it seems to
make sense with one exception which I have commented on separately.

In general, I still don't like the use of wake_up_all(), though it won't
cause incorrect behaviour.

I would prefer the first patch would:
- make reclaim_wait an array
- spelled nr_reclaim_throttled as nr_writeback_throttled

rather than leaving those changes for the second patch. I think that
would make review easier.

But these are minor and I'll not mention them again.


 \ /
  Last update: 2021-10-22 03:16    [W:0.130 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site