[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 18/18] spi: mxic: Add support for pipelined ECC operations
Hi Miquel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on mtd/nand/next mtd/mtd/next mtd/mtd/fixes v5.15-rc6 next-20211020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: for-next
config: riscv-randconfig-r004-20211019 (attached as .config)
compiler: clang version 14.0.0 ( 9660563950aaed54020bfdf0be07e7096a9553e4)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
git remote add linux-review
git fetch --no-tags linux-review Miquel-Raynal/External-ECC-engines-Macronix-support/20211020-223036
git checkout 9b602c348c84bbe0698c891b14e29cf25ef74b6a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

In file included from drivers/spi/spi-mxic.c:16:
>> include/linux/mtd/nand-ecc-mxic.h:23:29: warning: no previous prototype for function 'mxic_ecc_get_pipelined_ops' [-Wmissing-prototypes]
struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)
include/linux/mtd/nand-ecc-mxic.h:23:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)
1 warning generated.

vim +/mxic_ecc_get_pipelined_ops +23 include/linux/mtd/nand-ecc-mxic.h

ccf53b4df2cab6 Miquel Raynal 2021-10-20 22
ccf53b4df2cab6 Miquel Raynal 2021-10-20 @23 struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)
ccf53b4df2cab6 Miquel Raynal 2021-10-20 24 {
ccf53b4df2cab6 Miquel Raynal 2021-10-20 25 return NULL;
ccf53b4df2cab6 Miquel Raynal 2021-10-20 26 }
ccf53b4df2cab6 Miquel Raynal 2021-10-20 27

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2021-10-20 21:41    [W:0.139 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site