lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/2] dt-bindings: Add binding for Renesas 8T49N241
Hi Alex,

On Wed, Oct 20, 2021 at 6:57 PM Alex Helms
<alexander.helms.jy@renesas.com> wrote:
> On 10/20/2021 1:20 AM, Geert Uytterhoeven wrote:
> > On Tue, Oct 19, 2021 at 11:53 PM Alex Helms
> > <alexander.helms.jy@renesas.com> wrote:
> >> On 10/14/2021 5:16 AM, Geert Uytterhoeven wrote:
> >>> On Wed, Oct 13, 2021 at 8:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >>>> On Mon, Sep 13, 2021 at 7:05 PM Alex Helms
> >>>> <alexander.helms.jy@renesas.com> wrote:
> >>>>> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> >>>>> The 8T49N241 accepts up to two differential or single-ended input clocks
> >>>>> and a fundamental-mode crystal input. The internal PLL can lock to either
> >>>>> of the input reference clocks or to the crystal to behave as a frequency
> >>>>> synthesizer.
> >>>>>
> >>>>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
> >>>>> Reviewed-by: Rob Herring <robh@kernel.org>
> >>>>
> >>>> Thanks for your patch!
> >>>>
> >>>>> --- /dev/null
> >>>>> +++ b/Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> >>>
> >>>> BTW, do you plan to add interrupt and/or GPIO support later?
> >>>
> >>> To clarify, and I really meant to add:
> >>>
> >>> interrupts:
> >>> maxItems: 1
> >>>
> >>> to the bindings now, and GPIO-related properties and subnodes later.
> >>
> >> Any additional features such as interrupts and GPIO properties would only be added if there is customer demand for such features. Since there is no interrupt support, does the "interrupts" item still need to be added to the yaml?
> >
> > DT describes hardware, not software policy (or limitations of the driver).
> >
> > Arguably that applies to both interrupts and GPIOs, but the latter is
> > more complex to describe, while the former is a simple "interrupts"
> > property. It's not uncommon for board components to have their
> > interrupt line wired to an SoC, even if the driver doesn't use it.
>
> I understand what you are describing but I don't understand how it is
> relevant for this device. The device is a clock generator on the i2c
> bus. It has a few GPIOs that can be configured as outputs for specific
> events like loss of lock or loss of signal, but I don't understand why

According to the datasheet, the GPIOs can not only be used to indicate
clock generator status, but also as real GPIOs, e.g. to control LEDs
from software.

> that matters. 8t49n241 is similar to the existing dt and driver
> silabs,si5351 which does not define any interrupts. In fact it seems
> their dt describes both hardware and software policy because it uses
> custom dt keywords for changing driver behavior such as
> "silabs,pll-source" or "silabs,drive-strength". So looking at other
> examples of similar drivers, I don't understand why the 8t49n241
> driver needs to define an interrupt.

OK. So just ignore interrupts and GPIO for now.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2021-10-20 19:58    [W:0.099 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site