lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 08/14] x86/retpoline: Create a retpoline thunk array
From
Date
On 20/10/2021 16:57, Josh Poimboeuf wrote:
> On Wed, Oct 20, 2021 at 12:44:50PM +0200, Peter Zijlstra wrote:
>> Stick all the retpolines in a single symbol and have the individual
>> thunks as inner labels, this should guarantee thunk order and layout.
> How so?
>
> Just wondering what the purpose of the array is. It doesn't seem to be
> referenced anywhere.

The array property is what makes:

> + reg = (target - &__x86_indirect_thunk_rax) /
> + (&__x86_indirect_thunk_rcx - &__x86_indirect_thunk_rax);

safe in the next path.

~Andrew

\
 
 \ /
  Last update: 2021-10-20 18:48    [W:0.103 / U:1.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site