Messages in this thread |  | | Subject | Re: [PATCH v2 08/14] x86/retpoline: Create a retpoline thunk array | From | Andrew Cooper <> | Date | Wed, 20 Oct 2021 17:46:39 +0100 |
| |
On 20/10/2021 16:57, Josh Poimboeuf wrote: > On Wed, Oct 20, 2021 at 12:44:50PM +0200, Peter Zijlstra wrote: >> Stick all the retpolines in a single symbol and have the individual >> thunks as inner labels, this should guarantee thunk order and layout. > How so? > > Just wondering what the purpose of the array is. It doesn't seem to be > referenced anywhere.
The array property is what makes:
> + reg = (target - &__x86_indirect_thunk_rax) / > + (&__x86_indirect_thunk_rcx - &__x86_indirect_thunk_rax);
safe in the next path.
~Andrew
|  |