lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] dt-bindings: opp: Allow multi-worded node names
From
Date
20.10.2021 17:46, Rob Herring пишет:
> On Wed, Oct 20, 2021 at 02:19:05AM +0300, Dmitry Osipenko wrote:
>> Not all OPP table names and OPP entries consist of a single word. In
>> particular NVIDIA Tegra OPP tables use multi-word names. Allow OPP node
>> and OPP entry name to have multi-worded names to silence DT checker
>> warnings about the multi-word names separated by hyphen.
>>
>> Reviewed-by: David Heidelberg <david@ixit.cz>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> index ae3ae4d39843..298cf24af270 100644
>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> @@ -22,7 +22,7 @@ select: false
>>
>> properties:
>> $nodename:
>> - pattern: '^opp-table(-[a-z0-9]+)?$'
>> + pattern: '^opp-table(-[a-z0-9]+)*$'
>
> I don't see how this helps you. What I see needed upstream is a prefix:
>
> '-?opp-table(-[0-9]+)?$'
>
> Though really what I'd like to see is the OPP nodes moved into the
> device nodes they belong to when appropriate (i.e. when not shared
> between multiple devices).

I already prepared patches to rename Tegra OPP tables in accordance to
the new naming scheme where opp-table- is the prefix.

\
 
 \ /
  Last update: 2021-10-20 17:01    [W:0.120 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site