[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] s390: replace snprintf in show functions with sysfs_emit
Am 15.10.21 um 08:50 schrieb Qing Wang:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
> Fix the coccicheck warnings:
> WARNING: use scnprintf or sprintf.
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> Signed-off-by: Qing Wang <>
> ---
> drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------

Thanks for the DASD changes. While I am totally fine with the change
itself I agree with Joe's remark.
Would you like to improve your patch? Otherwise I can add a small follow
on patch. Just let me know.

 \ /
  Last update: 2021-10-20 16:45    [W:0.104 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site