lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: vt6655: Rename `dwAL2230InitTable` array
From
Date
On Wed, 2021-10-20 at 14:28 +0100, Karolina Drobnik wrote:
> Drop Hungarian notation prefix in `dwAL2230InitTable` array.
> Change it to use snake case.
>
> Fix issue detected by checkpatch.pl:
> CHECK: Avoid CamelCase: <dwAL2230InitTable>

Seems fine.

trivial suggestion:

> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
[]
> @@ -33,7 +33,7 @@
> #define SWITCH_CHANNEL_DELAY_AL7230 200 /* us */
> #define AL7230_PWR_IDX_LEN 64
>
> -static const unsigned long dwAL2230InitTable[CB_AL2230_INIT_SEQ] = {
> +static const unsigned long al2230_init_table[CB_AL2230_INIT_SEQ] = {
> 0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> 0x03333100 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> 0x01A00200 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,

In this file there are more than 100 uses of

(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW

Maybe add a define for it and substitute the uses for the define.


\
 
 \ /
  Last update: 2021-10-20 15:45    [W:1.124 / U:4.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site