Messages in this thread |  | | Date | Wed, 20 Oct 2021 16:22:24 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5] tty: Fix the keyboard led light display problem |
| |
On Wed, Oct 20, 2021 at 08:50:50PM +0800, lianzhi chang wrote: > Switching from the desktop environment to the tty environment, > the state of the keyboard led lights and the state of the keyboard > lock are inconsistent. This is because the attribute kb->kbdmode > of the tty bound in the desktop environment (xorg) is set to > VC_OFF, which causes the ledstate and kb->ledflagstate > values of the bound tty to always be 0, which causes the switch > from the desktop When to the tty environment, the LED light > status is inconsistent with the keyboard lock status.
Thank you for an update! My comments below.
...
> +static void kbd_update_ledstate(struct input_dev *dev) > +{ > + unsigned long leds; > + > + if (ledstate == -1U) > + ledstate = 0;
> + leds = (unsigned long)ledstate;
It's still unclear why do you need casting here.
> + if (!!test_bit(LED_NUML, dev->led) != !!test_bit(VC_NUMLOCK, &leds)) > + ledstate ^= BIT(VC_NUMLOCK); > + if (!!test_bit(LED_CAPSL, dev->led) != !!test_bit(VC_CAPSLOCK, &leds)) > + ledstate ^= BIT(VC_CAPSLOCK); > + if (!!test_bit(LED_SCROLLL, dev->led) != !!test_bit(VC_SCROLLOCK, &leds)) > + ledstate ^= BIT(VC_SCROLLOCK); > +}
...
> unsigned int leds; > unsigned long flags; > + struct kbd_struct *kb;
Can we use reversed xmas tree ordering as I showed previously, please?
-- With Best Regards, Andy Shevchenko
|  |