lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4] KVM: emulate: Don't inject #GP when emulating RDMPC if CR0.PE=0
On Wed, 20 Oct 2021 at 17:02, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 20/10/21 10:52, Wanpeng Li wrote:
> > From: Wanpeng Li<wanpengli@tencent.com>
> >
> > SDM mentioned that we should #GP for rdpmc if ECX is not valid or
> > (CR4.PCE is 0 and CPL is 1, 2, or 3 and CR0.PE is 1).
> >
> > Let's add the CR0.PE is 1 checking to rdpmc emulate, though this isn't
> > strictly necessary since it's impossible for CPL to be >0 if CR0.PE=0.
> >
> > Reviewed-by: Sean Christopherson<seanjc@google.com>
> > Signed-off-by: Wanpeng Li<wanpengli@tencent.com>
> > ---
> > v3 -> v4:
> > * add comments instead of pseudocode
>
> No, the commit message was fine. What I meant is there's no need to
> change the code. Just add a comment about why CR0.PE isn't tested.

Just sent out a new version.

Wanpeng

\
 
 \ /
  Last update: 2021-10-20 12:16    [W:0.067 / U:3.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site