lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 14/14] bpf,x86: Respect X86_FEATURE_RETPOLINE*
On Wed, Oct 20, 2021 at 05:07:53PM -0700, Alexei Starovoitov wrote:
> On Wed, Oct 20, 2021 at 12:44:56PM +0200, Peter Zijlstra wrote:
> > +
> > + if (cpu_feature_enabled(X86_FEATURE_RETPOLINE_AMD)) {
> > + EMIT_LFENCE();
> > + EMIT2(0xFF, 0xE0 + reg);
> > + } else if (cpu_feature_enabled(X86_FEATURE_RETPOLINE)) {
> > + emit_jump(&prog, reg_thunk[reg], ip);
> > + } else
>
> One more question.
> What's a deal with AMD? I thought the retpoline is effective on it as well.
> lfence is an optimization or retpoline turned out to be not enough
> in some cases?

Yes, it's basically an optimization. AMD recommends it presumably
because it's quite a bit faster than a retpoline.

According to AMD it shrinks the speculative execution window enough so
that Spectre v2 isn't a threat.

--
Josh

\
 
 \ /
  Last update: 2021-10-21 02:19    [W:0.144 / U:5.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site