lkml.org 
[lkml]   [2021]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] soundwire: qcom: add debugfs entry for soundwire register dump
HI Srini,

On 07-09-21, 11:56, Srinivas Kandagatla wrote:
> +#ifdef CONFIG_DEBUG_FS
> +static int swrm_reg_show(struct seq_file *s_file, void *data)
> +{
> + struct qcom_swrm_ctrl *swrm = s_file->private;
> + int reg, reg_val;
> +
> + for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {
> + swrm->reg_read(swrm, reg, &reg_val);

Why not use regmap_read here, that would avoid reading from the bus when
we already have the values...

Second make sure later when pm_runtime support is added, this take a
reference ..

Thanks
--
~Vinod

\
 
 \ /
  Last update: 2021-10-01 06:21    [W:0.041 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site