Messages in this thread Patch in this message |  | | From | matthias.bgg@kernel ... | Subject | [PATCH v2 3/3] regulator: mt6323: Add OF match table | Date | Sat, 9 Jan 2021 12:26:11 +0100 |
| |
From: Matthias Brugger <mbrugger@suse.com>
The binding documentation mentions that a compatible is required for the MT6323 device node. But the driver does not provide a OF match table. This way auto-loading is broken as the MFD driver that registers the device has a .of_compatible set which makes the platform .uevent callback report a OF modalias, but that's not in the module.
Fixes: 2fdf82923618 ("regulator: mt6323: Add support for MT6323 regulator") Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
Changes in v2: - check for CONFIG_OF - add Fixes tag
drivers/regulator/mt6323-regulator.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index ff9016170db3..646742d4db74 100644 --- a/drivers/regulator/mt6323-regulator.c +++ b/drivers/regulator/mt6323-regulator.c @@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = { }; MODULE_DEVICE_TABLE(platform, mt6323_platform_ids); +#ifdef CONFIG_OF +static const struct of_device_id mt6323_of_match[] = { + { .compatible = "mediatek,mt6323-regulator", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, mt6323_of_match); +#endif + static struct platform_driver mt6323_regulator_driver = { .driver = { .name = "mt6323-regulator", + .of_match_table = of_match_ptr(mt6323_of_match), }, .probe = mt6323_regulator_probe, .id_table = mt6323_platform_ids, -- 2.29.2
|  |