Messages in this thread |  | | From | "Chen, Mike Ximing" <> | Subject | RE: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls | Date | Sat, 9 Jan 2021 07:55:45 +0000 |
| |
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Thursday, January 7, 2021 2:42 PM > To: Chen, Mike Ximing <mike.ximing.chen@intel.com> > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Williams, Dan J > <dan.j.williams@intel.com>; pierre-louis.bossart@linux.intel.com; Gage Eads > <gage.eads@intel.com> > Subject: Re: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls > > > +/* [7:0]: device revision, [15:8]: device version */ > > +#define DLB_SET_DEVICE_VERSION(ver, rev) (((ver) << 8) | (rev)) > > + > > +static int > > +dlb_ioctl_get_device_version(struct dlb *dlb __attribute__((unused)), > > We don't use __attribute__((unused)) for function variables in Linux. > Please remove and tell whatever operating system you ported this from to > get with the times :) > > thanks, > > greg k-h
OK. Will remove __attribute__((unused)) in the patch set.
Thanks!
Mike
|  |