lkml.org 
[lkml]   [2021]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver
...
> > > +
> > > +#ifdef CONFIG_OF
> >
> > As a general rule, we are trying to clear out protections on CONFIG_OF etc
> > and use of of_match_ptr() on the basis they don't really gain us anything
> > and prevent use of some other firmware types. Here I guess you know what
> > your firmware looks like, but I'm still keen to drop it in the interests
> > of there being fewer places to copy it from.
> >
> > It may be a good idea to give this a more specific name as well given
> > we already have cros-ec-prox as a platform device id from
> > the cros_ec_light_prox driver.
>
> Alright. I renamed it to cros_ec_mkbp_proximity throughout this driver.
> I'm concerned about dropping CONFIG_OF because of_match_ptr() and
> CONFIG_OF=n makes it unused but I suppose that will be OK as long as
> compilation passes.

It's a trivial overhead + note that it can be used by certain ACPI
tables. Lookup the delights of PRP0001 which lets ACPI use
device-tree descriptions. It may well be that no one uses that for
this driver, but it's nice not to exclude it and that works with
CONFIG_OF=n.

Jonathan

\
 
 \ /
  Last update: 2021-01-31 13:15    [W:0.106 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site