lkml.org 
[lkml]   [2021]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE
On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Saravana,
>
> On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan <saravanak@google.com> wrote:
>
> > +static int __init imx_avic_init(struct device_node *node,
> > + struct device_node *parent)
> > +{
> > + void __iomem *avic_base;
> > +
> > + avic_base = of_iomap(node, 0);
> > + BUG_ON(!avic_base);
> > + mxc_init_irq(avic_base);
> > + return 0;
> > +}
> > +
> > +IRQCHIP_DECLARE(imx_avic, "fsl,imx31-avic", imx_avic_init);
>
> Shouldn't the compatible be "fsl,avic" instead?

Fabio,

Ah yes. I had that too. I deleted the wrong one in the last minute
before sending it out. Thanks for catching it.

I'll wait to see if there are any other review comments before I send out v2.

Martin,

Please make this fix before you test it.

-Saravana

\
 
 \ /
  Last update: 2021-02-01 03:25    [W:0.040 / U:2.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site