lkml.org 
[lkml]   [2021]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a newline
From
Date
On 1/30/21 3:08 AM, Joe Perches wrote:
> Add newline terminations to the sysfs_emit uses added by -next
> commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/misc/pvpanic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index b1e4922a7fda..9f350e05ef68 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -25,13 +25,13 @@ static unsigned int events;
> static ssize_t capability_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%x", capability);
> + return sysfs_emit(buf, "%x\n", capability);
> }
> static DEVICE_ATTR_RO(capability);
>
> static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%x", events);
> + return sysfs_emit(buf, "%x\n", events);
> }
>
> static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>
>

Hi, Greg is the maintainer of this driver.

--
zhenwei pi

\
 
 \ /
  Last update: 2021-02-01 03:00    [W:0.055 / U:8.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site