lkml.org 
[lkml]   [2021]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [Patch v3 net-next 0/7] ethtool support for fec and link configuration
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam <hkelam@marvell.com> wrote:
>
> This series of patches add support for forward error correction(fec) and
> physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
> mode configuration request and to fetch stats. Patch 3 registers driver
> callbacks for fec mode configuration and display. Patch 4&5 adds support of mbox
> handlers for configuring link parameters like speed/duplex and autoneg etc.
> Patche 6&7 registers driver callbacks for physical link configuration.
>
> Change-log:
> v2:
> - Fixed review comments
> - Corrected indentation issues
> - Return -ENOMEM incase of mbox allocation failure
> - added validation for input fecparams bitmask values
> - added more comments
>
> V3:
> - Removed inline functions
> - Make use of ethtool helpers APIs to display supported
> advertised modes
> - corrected indentation issues
> - code changes such that return early in case of failure
> to aid branch prediction

This addresses my comments to the previous patch series, thanks.

It seems that patchwork only picked up only patch 6/7 unfortunately:
https://patchwork.kernel.org/project/netdevbpf/list/?series=424969

>
> Christina Jacob (6):
> octeontx2-af: forward error correction configuration
> octeontx2-pf: ethtool fec mode support
> octeontx2-af: Physical link configuration support
> octeontx2-af: advertised link modes support on cgx
> octeontx2-pf: ethtool physical link status
> octeontx2-pf: ethtool physical link configuration
>
> Felix Manlunas (1):
> octeontx2-af: Add new CGX_CMD to get PHY FEC statistics
>
> drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 258 ++++++++++++-
> drivers/net/ethernet/marvell/octeontx2/af/cgx.h | 10 +
> .../net/ethernet/marvell/octeontx2/af/cgx_fw_if.h | 70 +++-
> drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 87 ++++-
> drivers/net/ethernet/marvell/octeontx2/af/rvu.h | 4 +
> .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 80 +++++
> .../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 ++
> .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +
> .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 399 ++++++++++++++++++++-
> .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 3 +
> 10 files changed, 930 insertions(+), 7 deletions(-)
>
> --
> 2.7.4

\
 
 \ /
  Last update: 2021-02-01 01:56    [W:0.043 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site