lkml.org 
[lkml]   [2021]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] serial: 8250: add option to disable registration of legacy ISA ports
Date
Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Thursday, January 28, 2021, Mans Rullgard <mans@mansr.com> wrote:
>
>> On systems that do not have the traditional PC ISA serial ports, the
>> 8250 driver still creates non-functional device nodes. This change
>> makes only ports that actually exist (PCI, DT, ...) get device nodes.
>>
>>
>
> This is kinda ABI breakage. At least this will break x86 platforms with
> HSUARTs (all modern ones) that are used in embedded systems.
>
> I think you would rather need an option to disable this and select it by
> the platforms where it is known not to break anything.

What exactly breaks? The new option is enabled by default, just like
the one right beside it (SERIAL_8250_PNP), so nothing at all changes
unless this is actively disabled. On a system that doesn't have those
ports, any attempt to access the device nodes produces some kind of
error. How is it breaking anything to not create device nodes for
hardware that doesn't exist?

--
Måns Rullgård

\
 
 \ /
  Last update: 2021-01-31 21:09    [W:0.087 / U:3.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site