lkml.org 
[lkml]   [2021]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 23/29] fuse: Avoid comma separated statements
    From
    Date
    On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
    > Use semicolons and braces.

    ping?

    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    >  fs/fuse/dir.c | 24 ++++++++++++++++--------
    >  1 file changed, 16 insertions(+), 8 deletions(-)
    >
    > diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
    > index 26f028bc760b..ecb6eed832a0 100644
    > --- a/fs/fuse/dir.c
    > +++ b/fs/fuse/dir.c
    > @@ -1362,14 +1362,22 @@ static void iattr_to_fattr(struct fuse_conn *fc, struct iattr *iattr,
    >  {
    >   unsigned ivalid = iattr->ia_valid;
    >  
    >
    > - if (ivalid & ATTR_MODE)
    > - arg->valid |= FATTR_MODE, arg->mode = iattr->ia_mode;
    > - if (ivalid & ATTR_UID)
    > - arg->valid |= FATTR_UID, arg->uid = from_kuid(fc->user_ns, iattr->ia_uid);
    > - if (ivalid & ATTR_GID)
    > - arg->valid |= FATTR_GID, arg->gid = from_kgid(fc->user_ns, iattr->ia_gid);
    > - if (ivalid & ATTR_SIZE)
    > - arg->valid |= FATTR_SIZE, arg->size = iattr->ia_size;
    > + if (ivalid & ATTR_MODE) {
    > + arg->valid |= FATTR_MODE;
    > + arg->mode = iattr->ia_mode;
    > + }
    > + if (ivalid & ATTR_UID) {
    > + arg->valid |= FATTR_UID;
    > + arg->uid = from_kuid(fc->user_ns, iattr->ia_uid);
    > + }
    > + if (ivalid & ATTR_GID) {
    > + arg->valid |= FATTR_GID;
    > + arg->gid = from_kgid(fc->user_ns, iattr->ia_gid);
    > + }
    > + if (ivalid & ATTR_SIZE) {
    > + arg->valid |= FATTR_SIZE;
    > + arg->size = iattr->ia_size;
    > + }
    >   if (ivalid & ATTR_ATIME) {
    >   arg->valid |= FATTR_ATIME;
    >   arg->atime = iattr->ia_atime.tv_sec;


    \
     
     \ /
      Last update: 2021-01-30 20:06    [W:4.600 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site