lkml.org 
[lkml]   [2021]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 19/29] s390/tty3270: Avoid comma separated statements
From
Date
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

ping?

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/s390/char/tty3270.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c
> index aec996de44d9..6acce975df26 100644
> --- a/drivers/s390/char/tty3270.c
> +++ b/drivers/s390/char/tty3270.c
> @@ -424,8 +424,10 @@ tty3270_update(struct timer_list *t)
>   * last output position matches the start address
>   * of this line.
>   */
> - if (s->string[1] == sba[0] && s->string[2] == sba[1])
> - str += 3, len -= 3;
> + if (s->string[1] == sba[0] && s->string[2] == sba[1]) {
> + str += 3;
> + len -= 3;
> + }
>   if (raw3270_request_add_data(wrq, str, len) != 0)
>   break;
>   list_del_init(&s->update);


\
 
 \ /
  Last update: 2021-01-30 20:03    [W:0.329 / U:5.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site