lkml.org 
[lkml]   [2021]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/29] drm/gma500: Avoid comma separated statements
From
Date
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

Ping?

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +++++++++++++-------
>  1 file changed, 28 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index aae2d358364c..bfa330df9443 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -824,33 +824,45 @@ static int mdfld_crtc_mode_set(struct drm_crtc *crtc,
>   if ((ksel == KSEL_CRYSTAL_19) || (ksel == KSEL_BYPASS_19)) {
>   refclk = 19200;
>  
>
> - if (is_mipi || is_mipi2)
> - clk_n = 1, clk_p2 = 8;
> - else if (is_hdmi)
> - clk_n = 1, clk_p2 = 10;
> + if (is_mipi || is_mipi2) {
> + clk_n = 1;
> + clk_p2 = 8;
> + } else if (is_hdmi) {
> + clk_n = 1;
> + clk_p2 = 10;
> + }
>   } else if (ksel == KSEL_BYPASS_25) {
>   refclk = 25000;
>  
>
> - if (is_mipi || is_mipi2)
> - clk_n = 1, clk_p2 = 8;
> - else if (is_hdmi)
> - clk_n = 1, clk_p2 = 10;
> + if (is_mipi || is_mipi2) {
> + clk_n = 1;
> + clk_p2 = 8;
> + } else if (is_hdmi) {
> + clk_n = 1;
> + clk_p2 = 10;
> + }
>   } else if ((ksel == KSEL_BYPASS_83_100) &&
>   dev_priv->core_freq == 166) {
>   refclk = 83000;
>  
>
> - if (is_mipi || is_mipi2)
> - clk_n = 4, clk_p2 = 8;
> - else if (is_hdmi)
> - clk_n = 4, clk_p2 = 10;
> + if (is_mipi || is_mipi2) {
> + clk_n = 4;
> + clk_p2 = 8;
> + } else if (is_hdmi) {
> + clk_n = 4;
> + clk_p2 = 10;
> + }
>   } else if ((ksel == KSEL_BYPASS_83_100) &&
>   (dev_priv->core_freq == 100 ||
>   dev_priv->core_freq == 200)) {
>   refclk = 100000;
> - if (is_mipi || is_mipi2)
> - clk_n = 4, clk_p2 = 8;
> - else if (is_hdmi)
> - clk_n = 4, clk_p2 = 10;
> + if (is_mipi || is_mipi2) {
> + clk_n = 4;
> + clk_p2 = 8;
> + } else if (is_hdmi) {
> + clk_n = 4;
> + clk_p2 = 10;
> + }
>   }
>  
>
>   if (is_mipi)


\
 
 \ /
  Last update: 2021-01-30 19:49    [W:0.645 / U:25.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site