lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iov_iter: optimise iter type checking
On Wed, Jan 27, 2021 at 04:28:38PM +0000, David Laight wrote:

> I'd definitely leave the type as a bitmap.

What the hell for? Microoptimizations in places where we have
much heavier stuff to be done are bloody pointless.

It's already overcomplicated. And compiler is _not_ going to
be able to prove that we'll only ever have one bit set, so
you would be making it harder to optimize, not to mention
reason about.

\
 
 \ /
  Last update: 2021-01-27 19:32    [W:0.092 / U:1.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site