lkml.org 
[lkml]   [2021]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging
On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Cleanup the use of dev_foo functions used for logging:
>
> 1. Many of these are unnecessarily split over multiple lines
> 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER
> return value

...

> if (IS_ERR(info->micd_pol_gpio)) {
> ret = PTR_ERR(info->micd_pol_gpio);
> - dev_err(arizona->dev,
> - "Failed to get microphone polarity GPIO: %d\n",
> - ret);
> + dev_err_probe(arizona->dev, ret, "getting microphone polarity GPIO\n");
> return ret;
> }

I still think that using dev_err_probe() naturally, i.e. as a part of
the return statement is better.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-01-24 20:55    [W:0.111 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site