lkml.org 
[lkml]   [2021]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module
From
Date
24.01.2021 01:50, Linus Walleij пишет:
> On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
>> This small series adds modularization support to the gpio-tegra driver,
>> i.e. driver now could be built as a loadable kernel module.
>>
>> Dmitry Osipenko (3):
>> gpio: tegra: Use debugfs_create_devm_seqfile()
>> gpio: tegra: Clean up whitespaces in tegra_gpio_driver
>> gpio: tegra: Support building driver as a loadable module
>
> As these three patches clearly make the kernel look better after
> than before:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> However when we are doing this I would strongly encourage you
> to also make a patch implementing remove() so you can insmod
> rmmod the module at runtime.

The remove() is optional for drivers, it doesn't prevent the rmmod.

\
 
 \ /
  Last update: 2021-01-24 00:58    [W:0.203 / U:24.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site