lkml.org 
[lkml]   [2021]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 1/2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
On Thu, 21 Jan 2021 16:56:58 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:

> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> the accelerometer part.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Just the issue the build bot found. Otherwise looks good to me.

Jonathan

>
> ---
>
> Changes in v7:
> Add additionalProperties
> Change bmi088_accel to bmi088-accel
> Add interrupt-names and adjust description
>
> Changes in v6:
> I't been almost a year since the last commit, sorry...
> Fixed the yaml errors
> Add interrupt, vdd and vddio properties
>
> Changes in v5:
> submit together with driver code as patch series
>
> Changes in v2:
> convert to yaml format
>
> .../bindings/iio/accel/bosch,bmi088.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> new file mode 100644
> index 000000000000..db5dbaf80fa2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/bosch,bmi088.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch BMI088 IMU accelerometer part
> +
> +maintainers:
> + - Mike Looijmans <mike.looijmans@topic.nl>
> +
> +description: |
> + Acceleration part of the IMU sensor with an SPI interface
> + Specifications about the sensor can be found at:
> + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - bosch,bmi088-accel
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> + vddio-supply: true
> +
> + interrupts:
> + minItems: 1
> + maxItems: 2
> + description: |
> + Type should be either IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_LEVEL_LOW.
> + Two configurable interrupt lines exist.
> +
> + interrupt-names:
> + description: Specify which interrupt line is in use.
> + items:
> + enum:
> + - INT1
> + - INT2
> + minItems: 1
> + maxItems: 2

As per Rob's build bot you need.

spi-max-frequency: true

If that's all that comes up and Rob is happy with this I can fix that up whilst
applying. Please try to run the checks suggested in Rob's build bot message
before submitting binding patches though.


> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + bmi088-accel@1 {
> + compatible = "bosch,bmi088-accel";
> + reg = <1>;
> + spi-max-frequency = <10000000>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "INT2";
> + };
> + };
> +...

\
 
 \ /
  Last update: 2021-01-23 16:40    [W:0.227 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site