lkml.org 
[lkml]   [2021]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: typec: tcpci_maxim: remove redundant assignment
From
Date
On 1/23/21 2:14 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> PTR_ERR(chip->tcpci) has been used as a return value,
> it is not necessary to assign it to ret, so remove it.
>
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/usb/typec/tcpm/tcpci_maxim.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 3192663..7f54f51a 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -461,7 +461,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id
> chip->tcpci = tcpci_register_port(chip->dev, &chip->data);
> if (IS_ERR(chip->tcpci)) {
> dev_err(&client->dev, "TCPCI port registration failed");
> - ret = PTR_ERR(chip->tcpci);
> return PTR_ERR(chip->tcpci);
> }
> chip->port = tcpci_get_tcpm_port(chip->tcpci);
>

\
 
 \ /
  Last update: 2021-01-23 15:31    [W:0.077 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site