lkml.org 
[lkml]   [2021]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()
On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote:
> @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum cpuhp_state state,
>
> if (st->fail == state) {
> st->fail = CPUHP_INVALID;
> -
> - if (!(bringup ? step->startup.single : step->teardown.single))
> - return 0;
> -
> return -EAGAIN;
> }
>
> + if (cpuhp_step_empty(bringup, step)) {
> + WARN_ON_ONCE(1);
> + return 0;
> + }

This changes the behaviour of fail.. might be best to refactor without
changing behaviour.

Lemme continue reading.

\
 
 \ /
  Last update: 2021-01-20 15:48    [W:0.104 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site