lkml.org 
[lkml]   [2021]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open
From
Date
Hi,

On 1/19/21 6:53 PM, Jiri Kosina wrote:
> On Mon, 25 Jul 2016, Jens Axboe wrote:
>
>>> From: Jiri Kosina <jkosina@suse.cz>
>>>
>>> Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
>>> side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
>>> this is being used setfdprm userspace for ioctl-only open().
>>>
>>> Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
>>> modes, while still keeping the original O_NDELAY bug fixed.
>>>
>>> Cc: stable@vger.kernel.org # v4.5+
>>> Reported-by: Wim Osterholt <wim@djo.tudelft.nl>
>>> Tested-by: Wim Osterholt <wim@djo.tudelft.nl>
>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>
>> Added for this series, thanks.
>
> [ CCing Denis too ]
>
> Let me revive this 4 years old thread.
>
> I've just now noticed that instead of my patch above being merged, what
> happened instead was
>
> commit f2791e7eadf437633f30faa51b30878cf15650be
> Author: Jens Axboe <axboe@fb.com>
> Date: Thu Aug 25 08:56:51 2016 -0600
>
> Revert "floppy: refactor open() flags handling"
>
> This reverts commit 09954bad448791ef01202351d437abdd9497a804.
>
>
> which was plain revert of 09954bad4 (without any further explanation),
> which in turn reintroduced the O_NDELAY issue, and I've just been hit by
> it again.
>
> I am not able to find any e-mail thread that'd indicate why ultimately
> revert happened, instead of mergin my fix.

I think it's hard to recall the exact reasons after so many years.
I'll send a patch today based on this one.

Best Regards,
Denis

\
 
 \ /
  Last update: 2021-01-21 05:54    [W:0.108 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site