lkml.org 
[lkml]   [2021]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps
From
Date
On 1/18/21 12:26 PM, Matthew Wilcox wrote:
> Don't make it easy. And don't make it look like they're doing
> something innocent. DUMP_PREFIX_SECURITY_HOLE would be OK
> by me. DUMP_PREFIX_LEAK_INFORMATION would work fine too.
> DUMP_PREFIX_MAKE_ATTACKERS_LIFE_EASY might be a bit too far.

It's already extremely easy to replace %p with %px in your own printks,
so I don't really understand your argument.

Seriously, this patch should not be so contentious. If you want hashed
addresses, then nothing changes. If you need unhashed addresses while
debugging, then use DUMP_PREFIX_UNHASHED. Just like you can use %px in
printk. I never use %p in my printks, but then I never submit code
upstream that prints addresses, hashed or unhashed.

\
 
 \ /
  Last update: 2021-01-18 20:07    [W:0.195 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site