lkml.org 
[lkml]   [2021]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] block: Fix an error handling in add_partition
> On 1/15/21 11:34 PM, Dinghao Liu wrote:
> > Once we have called device_initialize(), we should
> > use put_device() to give up the reference on error,
> > just like what we have done on failure of device_add().
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> Please consider having following commit message, since above
> commit message is looking odd from what we have in the tree :-
>
>
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>

Thanks for this suggestion!

>
> Also have you tested this patch with the with generating appropriate error ?
>

No, this problem is found through comparing existing source code.

Regards,
Dinghao
\
 
 \ /
  Last update: 2021-01-16 12:11    [W:0.041 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site