lkml.org 
[lkml]   [2021]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
Date
(sorry for only seeing this late)

[...]
> +maintainers:
> + - John Crispin <john@phrozen.org>
personally I think we should get at least John's Acked-by but I don't
know if there's any rule for adding a dt-binding for some other
maintainer

[...]
> +required:
> + - compatible
> + - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings"
from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board

Also the Lantiq code does not use the common clock framework yet. Once
that's used we also need #clock-cells = <1>. I don't know if that
should be added already (or not).

> +examples:
> + - |
> + cgu@103000 {
this should be clock-controller@...


Best regards,
Martin


[0] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html

\
 
 \ /
  Last update: 2021-01-16 21:31    [W:0.044 / U:2.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site