lkml.org 
[lkml]   [2021]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller
On Tue, Jan 12, 2021 at 08:36:49PM +0100, Andreas Kemnade wrote:
> On Sat, 9 Jan 2021 19:02:16 +0100
> Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
[...]
> > +static const struct of_device_id of_ntxec_match_table[] = {
> > + { .compatible = "netronix,ntxec", },
> > + {}
> > +};
> > +
> MODULE_DEVICE_TABLE?

Yes, good idea.

> > +static struct i2c_driver ntxec_driver = {
> > + .driver = {
> > + .name = "ntxec",
> > + .of_match_table = of_ntxec_match_table,
> > + },
> > + .probe_new = ntxec_probe,
> > + .remove = ntxec_remove,
> > +};
> > +module_i2c_driver(ntxec_driver);
>
> MODULE_LICENSE()?
>
> modpost moans about that here.

I forgot those. Thanks for noticing.
I'll add the MODULE_ lines in v8.



Thanks,
Jonathan
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-01-14 20:00    [W:0.182 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site