lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] Input: omap4-keypad - use PM runtime autosuspend
* Dmitry Torokhov <dmitry.torokhov@gmail.com> [210111 05:01]:
> Hi Tony,
>
> On Sun, Jan 10, 2021 at 09:05:28PM +0200, Tony Lindgren wrote:
> > @@ -350,15 +379,12 @@ static int omap4_keypad_probe(struct platform_device *pdev)
> >
> > error = omap4_keypad_check_revision(&pdev->dev,
> > keypad_data);
> > - if (!error) {
> > - /* Ensure device does not raise interrupts */
> > - omap4_keypad_stop(keypad_data);
> > - }
> > -
> > - pm_runtime_put_sync(&pdev->dev);
>
> Why are we moving this down? The idea was to make sure the power usage
> counters are correct even if we exit probe early.

Yes you are right, omap4_keypad_close() won't help with balancing the
get if we exit early.

> Can we call pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend()
> here?

Yes that should work as there's no more register access during the probe.

Regards,

Tony

\
 
 \ /
  Last update: 2021-01-11 06:15    [W:0.065 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site