lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support
On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote:
> > On Sun, 10 Jan 2021 21:23:02 +0200 stefanc@marvell.com wrote:
> > > From: Stefan Chulski <stefanc@marvell.com>
> > >
> > > Packet Processor hardware not connected to MAC flow control unit and
> > > cannot support TX flow control.
> > > This patch disable flow control support.
> > >
> > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> > > Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> >
> > I'm probably missing something, but why not 4bb043262878 ("net: mvpp2:
> > phylink support")?
>
> Hi Jakub
>
> Before that change, it used phylib. The same is true with phylib, you
> need to tell phylib it should not advertise pause. How you do it is
> different, but the basic issue is the same. Anybody doing a backport
> past 4bb043262878is going to need a different fix, but the basic issue
> is there all the way back to when the driver was added.

Thanks for confirming, I didn't see any code being removed which would
tell phylib pause is supported, so I wanted to make sure phylib
defaults to on / gets it from some register.

Applied now, thanks!

\
 
 \ /
  Last update: 2021-01-12 01:59    [W:0.046 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site