Messages in this thread |  | | From | Rob Herring <> | Date | Mon, 11 Jan 2021 09:42:54 -0600 | Subject | Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings |
| |
On Sun, Jan 10, 2021 at 8:52 PM Henry Chen <henryc.chen@mediatek.com> wrote: > > Hi Rob, > > On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote: > > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote: > > > Document the binding for enabling dvfsrc on MediaTek SoC. > > > > > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com> > > > --- > > > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 67 ++++++++++++++++++++++ > > > 1 file changed, 67 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory > > 19 | #include <dt-bindings/interconnect/mtk,mt8183-emi.h> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Sorry, because this header file is added on "[V7,07/13] dt-bindings: > interconnect: add MT8183 interconnect dt-bindings". > Should I change the order of the patchset (let the yaml pathc behind the > header) to fixed that ?
DT headers should be part of the binding schema patch. (Or at least come first).
Rob
|  |