lkml.org 
[lkml]   [2021]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table
From
Date


On 09/01/2021 17:44, Frank Wunderlich wrote:
> Hi
>
>> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr
>> Von: matthias.bgg@kernel.org
>
>> Changes in v2:
>> - check for CONFIG_OF
>> - add Fixes tag
>
>> --- a/drivers/regulator/mt6323-regulator.c
>> +++ b/drivers/regulator/mt6323-regulator.c
>> @@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = {
>> };
>> MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id mt6323_of_match[] = {
>> + { .compatible = "mediatek,mt6323-regulator", },
>> + { /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, mt6323_of_match);
>> +#endif
>> +
>> static struct platform_driver mt6323_regulator_driver = {
>> .driver = {
>> .name = "mt6323-regulator",
>> + .of_match_table = of_match_ptr(mt6323_of_match),
>
> imho check for CONFIG_OF is here needed too, else mt6323_of_match is referenced but undefined
>

No, of_match_ptr already takes care of this:
https://elixir.bootlin.com/linux/latest/source/include/linux/of.h#L998

Regards,
Matthias

\
 
 \ /
  Last update: 2021-01-10 19:51    [W:0.074 / U:1.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site