lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970
Date
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Em Mon, 7 Sep 2020 17:59:34 +0200
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
>
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 8852fbfdead4..2d497165efe2 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>> * Some controllers need to toggle the usb3-otg reset before trying to
>> * initialize the PHY, otherwise the PHY times out.
>> */
>> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
>> + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
>> + of_device_is_compatible(np, "hisilicon,hi3670-dwc3"))
>> simple->need_reset = true;
>
> It turns that this hunk caused Serror during my suspend/resume tests.
>
> Without this one, the driver works just fine.
>
> As you already applied this patch, do you prefer a patch dropping it,
> or should I send a version 2 without it?

Send me a new one, I'll remove the patch.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-08 09:45    [W:0.060 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site