lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] mmc: host: Enable compile testing of multiple drivers
On Tue, 8 Sep 2020 at 15:54, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> + Arnd
>
> On Mon, 7 Sep 2020 at 12:53, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Multiple MMC host controller driver can be compile tested as they do not
> > depend on architecture specific headers.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> It seems like this is causing build errors for my next branch when
> running allmod config [1].
>
> [...]
>
> >
> > config MMC_S3C
> > tristate "Samsung S3C SD/MMC Card Interface support"
> > - depends on ARCH_S3C24XX
> > + depends on ARCH_S3C24XX || COMPILE_TEST
> > depends on S3C24XX_DMAC
> > help
> > This selects a driver for the MCI interface found in
>
> [...]
>
> The problem doesn't exist in linux-next, since it has the
> corresponding cleanup/rework patches for MMC_S3C from Arnd.
>
> To fix the problem, we should probably remove COMPILE_TEST for
> MMC_S3C, for now. Then we can add it again and send it as a fix for
> v5.10-rc1.
>
> What do you think?

Yes, better to remove it otherwise it will pop up when Linus merges
your tree. Do you want a patch for this or you fix it up by yourself?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-09-08 21:54    [W:0.063 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site