Messages in this thread |  | | Subject | Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices | From | Jonathan Marek <> | Date | Tue, 8 Sep 2020 09:57:43 -0400 |
| |
On 9/8/20 9:56 AM, Pierre-Louis Bossart wrote: > > > >> @@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device >> *pdev) >> if (!ctrl->regmap) >> return -EINVAL; >> } else { >> - /* Only WCD based SoundWire controller is supported */ >> - return -ENOTSUPP; >> + ctrl->reg_read = qcom_swrm_cpu_reg_read; >> + ctrl->reg_write = qcom_swrm_cpu_reg_write; >> + ctrl->mmio = devm_platform_ioremap_resource(pdev, 0); >> + if (IS_ERR(ctrl->mmio)) >> + return PTR_ERR(ctrl->mmio); > > Shouldn't this be conditional on SLIMBUS being enabled, as done in your > patch2? >
No, the case above is the SLIMBUS case. This patch is adding support for the non-SLIMBUS case.
>> } >> ctrl->irq = of_irq_get(dev->of_node, 0); >>
|  |