lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/23] gpio: mockup: fix resource leak in error path
On Mon, Sep 07, 2020 at 01:04:59PM +0200, Bartosz Golaszewski wrote:
> On Fri, Sep 4, 2020 at 7:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Sep 04, 2020 at 05:45:34PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > If the module init function fails after creating the debugs directory,
> > > it's never removed. Add proper cleanup calls to avoid this resource
> > > leak.
> >
> > Does it fix existing bug?
>
> You mean - should it go into stable? The bug is quite unlikely but
> yeah, probably.

Yes. That sounds to me like Fixes: is needed.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-09-07 13:47    [W:0.086 / U:36.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site