lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] use generic_file_buffered_read()
From
Date
On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote:
> > Bean Huo (2):
> > block: use generic_file_buffered_read()
> > fs: isofs: use generic_file_buffered_read()
>
> The change is fine, but the title/commit message should reflect that
> this is just a comment change. The way it currently reads, it sounds
> like a functional change where something is switched over to using
> generic_file_buffered_read().
>

Hi Jens
Indeed, it's easy to mistake this for a functional change, but it's
actually a comment change. I have corrected them in the new patch, you
can check now.

thanks,
Bean

\
 
 \ /
  Last update: 2020-09-07 13:38    [W:0.172 / U:4.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site