lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"
From
Date
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore:
> with it applied, WiFi stops working, and the Kernel starts printing
> this message every second:
>
> wlcore: PHY firmware version: Rev 8.2.0.0.242
> wlcore: firmware booted (Rev 8.9.0.0.79)
> wlcore: ERROR command execute failure 14
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 133 at drivers/net/wireless/ti/wlcore/main.c:795 wl12xx_queue_recovery_work.part.0+0x6c/0x74 [wlcore]
> Modules linked in: wl18xx wlcore mac80211 libarc4 cfg80211 rfkill snd_soc_hdmi_codec crct10dif_ce wlcore_sdio adv7511 cec kirin9xx_drm(C) kirin9xx_dw_drm_dsi(C) drm_kms_helper drm ip_tables x_tables ipv6 nf_defrag_ipv6
> CPU: 0 PID: 133 Comm: kworker/0:1 Tainted: G WC 5.8.0+ #186
> Hardware name: HiKey970 (DT)
> Workqueue: events_freezable ieee80211_restart_work [mac80211]
> pstate: 60000005 (nZCv daif -PAN -UAO BTYPE=--)
> pc : wl12xx_queue_recovery_work.part.0+0x6c/0x74 [wlcore]
> lr : wl12xx_queue_recovery_work+0x24/0x30 [wlcore]
> sp : ffff8000126c3a60
> x29: ffff8000126c3a60 x28: 00000000000025de
> x27: 0000000000000010 x26: 0000000000000005
> x25: ffff0001a5d49e80 x24: ffff8000092cf580
> x23: ffff0001b7c12623 x22: ffff0001b6fcf2e8
> x21: ffff0001b7e46200 x20: 00000000fffffffb
> x19: ffff0001a78e6400 x18: 0000000000000030
> x17: 0000000000000001 x16: 0000000000000001
> x15: ffff0001b7e46670 x14: ffffffffffffffff
> x13: ffff8000926c37d7 x12: ffff8000126c37e0
> x11: ffff800011e01000 x10: ffff8000120526d0
> x9 : 0000000000000000 x8 : 3431206572756c69
> x7 : 6166206574756365 x6 : 0000000000000c2c
> x5 : 0000000000000000 x4 : ffff0001bf1361e8
> x3 : ffff0001bf1790b0 x2 : 0000000000000000
> x1 : ffff0001a5d49e80 x0 : 0000000000000001
> Call trace:
> wl12xx_queue_recovery_work.part.0+0x6c/0x74 [wlcore]
> wl12xx_queue_recovery_work+0x24/0x30 [wlcore]
> wl1271_cmd_set_sta_key+0x258/0x25c [wlcore]
> wl1271_set_key+0x7c/0x2dc [wlcore]
> wlcore_set_key+0xe4/0x360 [wlcore]
> wl18xx_set_key+0x48/0x1d0 [wl18xx]
> wlcore_op_set_key+0xa4/0x180 [wlcore]
> ieee80211_key_enable_hw_accel+0xb0/0x2d0 [mac80211]
> ieee80211_reenable_keys+0x70/0x110 [mac80211]
> ieee80211_reconfig+0xa00/0xca0 [mac80211]
> ieee80211_restart_work+0xc4/0xfc [mac80211]
> process_one_work+0x1cc/0x350
> worker_thread+0x13c/0x470
> kthread+0x154/0x160
> ret_from_fork+0x10/0x30
> ---[ end trace b1f722abf9af5919 ]---
> wlcore: WARNING could not set keys
> wlcore: ERROR Could not add or replace key
> wlan0: failed to set key (4, ff:ff:ff:ff:ff:ff) to hardware (-5)
> wlcore: Hardware recovery in progress. FW ver: Rev 8.9.0.0.79
> wlcore: pc: 0x0, hint_sts: 0x00000040 count: 39
> wlcore: down
> wlcore: down
> ieee80211 phy0: Hardware restart was requested
> mmc_host mmc0: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0)
> mmc_host mmc0: Bus speed (slot 0) = 25000000Hz (slot req 25000000Hz, actual 25000000HZ div = 0)
> wlcore: PHY firmware version: Rev 8.2.0.0.242
> wlcore: firmware booted (Rev 8.9.0.0.79)
> wlcore: ERROR command execute failure 14
> ------------[ cut here ]------------
>
> Tested on Hikey 970.
>
> This reverts commit 2b7aadd3b9e17e8b81eeb8d9cc46756ae4658265.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Patch applied to wireless-drivers.git, thanks.

1264c1e0cfe5 Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

--
https://patchwork.kernel.org/patch/11737193/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-09-07 10:41    [W:0.460 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site