lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family
From
Date
Hi Krzysztof,

On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The S3C RTC requires 32768 Hz clock as input which is provided by PMIC.
> However there is no such clock provider but rather a regulator driver
> which registers the clock as a regulator. This is an old driver which
> will not be updated so add a workaround - a fixed-clock to fill missing
> clock phandle reference in S3C RTC.
>
> This fixes dtbs_check warnings:
>
> rtc@e2800000: clocks: [[2, 145]] is too short
> rtc@e2800000: clock-names: ['rtc'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 6ba23562da46..86c3b26fd21e 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -47,6 +47,13 @@
> };
> };
>
> + pmic_ap_clk: clock-0 {
> + /* Workaround for missing clock on PMIC */
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + };
> +
> bt_codec: bt_sco {
> compatible = "linux,bt-sco";
> #sound-dai-cells = <0>;
> @@ -825,6 +832,11 @@
> samsung,pwm-outputs = <1>;
> };
>
> +&rtc {
> + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>;
> + clock-names = "rtc", "rtc_src";

Missing a

status = "okay";

here, but with that it works fine for me. Looks like it's also
missing in the patches for the other devices as well.

Thanks for the series of cleanups,
Jonathan

> +};
> +
> &sdhci1 {
> #address-cells = <1>;
> #size-cells = <0>;
>

\
 
 \ /
  Last update: 2020-09-08 01:59    [W:0.240 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site