lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases
From
Date
On 07/09/2020 19:47, Pali Rohár wrote:
> On Monday 07 September 2020 19:43:08 Andre Heider wrote:
>> On 07/09/2020 19:35, Pali Rohár wrote:
>>> On Monday 07 September 2020 19:23:03 Andrew Lunn wrote:
>>>>> My dts-foo is a little rusty, but now that you labeled the ports in the
>>>>> .dtsi, can this whole "switch0" block reduced to something like:
>>>>>
>>>>> &switch0port1 {
>>>>> label = "lan1";
>>>>> };
>>>>>
>>>>> &switch0port3 {
>>>>> label = "wan";
>>>>> };
>>>>
>>>> Probably yes.
>>>>
>>>> But that is definitely too much for stable.
>>>
>>> Yes, this suggested change is not for stable, but looks like a nice
>>> cleanup. So it could be done in followup patch.
>>>
>>> Andre, are you going to prepare and test this followup change?
>>
>> I can prep the patch if you like, but the suggested cleanup only affects the
>> v7 dts files. I don't have that hardware version to test it, so could only
>> send an untested patch.
>
> As a result of this cleanup should be binary DTB file for V7 with same
> structure as DTB file without such cleanup patch, right? And this test
> (structure / content of compiled file) does not need particular hardware.

Ok, will do.

\
 
 \ /
  Last update: 2020-09-07 19:51    [W:0.049 / U:6.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site