lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net] net: macb: fix for pause frame receive enable bit
From
Date
On 05/09/2020 at 10:21, Parshuram Thombare wrote:
> PAE bit of NCFGR register, when set, pauses transmission
> if a non-zero 802.3 classic pause frame is received.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>

For the record:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Parshuram for having found this issue.
Best regards,
Nicolas

> ---
> drivers/net/ethernet/cadence/macb_main.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6761f40..9179f7b 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,
> ctrl |= GEM_BIT(GBE);
> }
>
> - /* We do not support MLO_PAUSE_RX yet */
> - if (tx_pause)
> + if (rx_pause)
> ctrl |= MACB_BIT(PAE);
>
> macb_set_tx_clk(bp->tx_clk, speed, ndev);
> --
> 1.7.1
>


--
Nicolas Ferre

\
 
 \ /
  Last update: 2020-09-07 09:15    [W:0.050 / U:29.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site