[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] tracing: fix double free
From: Tom Rix <>

clang static analyzer reports this problem

trace_events_hist.c:3824:3: warning: Attempt to free
released memory

In parse_var_defs() if there is a problem allocating
var_defs.expr, the earlier is freed.
This free is duplicated by free_var_defs() which frees
the rest of the list.

Because free_var_defs() has to run anyway, remove the
second free fom parse_var_defs().

Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers")
Signed-off-by: Tom Rix <>
kernel/trace/trace_events_hist.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 0b933546142e..1b2ef6490229 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -3865,7 +3865,6 @@ static int parse_var_defs(struct hist_trigger_data *hist_data)

s = kstrdup(field_str, GFP_KERNEL);
if (!s) {
- kfree(hist_data->attrs->[n_vars]);
ret = -ENOMEM;
goto free;
 \ /
  Last update: 2020-09-07 19:19    [W:0.039 / U:2.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site