lkml.org 
[lkml]   [2020]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v6 18/18] crypto: sun8i-ce: fix some style issue
From
Date
On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote:
> This patch fix a double empty line issue reported by checkpatch.
> While at it, since now the maximum line length is now 100, reorder some
> wrapped line.
[]
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
[]
> @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req
> goto theend_key;
> }
> offset = areq->cryptlen - ivsize;
> - scatterwalk_map_and_copy(rctx->backup_iv, areq->src,
> - offset, ivsize, 0);
> + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, offset, ivsize, 0);
> }
> memcpy(rctx->bounce_iv, areq->iv, ivsize);
> - addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen,
> - DMA_TO_DEVICE);
> + addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, DMA_TO_DEVICE);

coding-style.rst:

Statements longer than 80 columns should be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does
not hide information.

Do these longer lines make the code significantly more readable?
I don't think they do.


\
 
 \ /
  Last update: 2020-09-04 21:38    [W:0.153 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site